Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database needs a refactor #83

Open
ccoverstreet opened this issue May 11, 2021 · 2 comments
Open

Database needs a refactor #83

ccoverstreet opened this issue May 11, 2021 · 2 comments

Comments

@ccoverstreet
Copy link
Owner

Each separate table or map should be split into its own file in core/database. The DBHandler should only be a combination of these sub-maps
@ccoverstreet
Copy link
Owner Author

ccoverstreet commented May 11, 2021 •
edited
Loading

This definitely helps with the design and maintanence. The database struct just combines method calls from the table to get the same results with less code in the control flow portions (514d727)

@ccoverstreet
Copy link
Owner Author

Some of the recent commits to jabko-micro have refactored parts of the database. The pmod table has not been split off since the exact implementation isn't quite resolved yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ccoverstreet