Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABSaturator | getDrive() returns linear value while setDrive() wants values in dB #39

Open
mariobuoninfante opened this issue Aug 28, 2019 · 0 comments

Comments

@mariobuoninfante
Copy link

mariobuoninfante commented Aug 28, 2019

At row 121 we have:
`
float setDrive(float d)
{
m_drive = dB2lin(d);
return m_drive;
}

float getDrive() { return m_drive; }

`

I think the 2 should use the same value
I had a the following scenario:
ABSaturator saturator[2]; 35 => saturator[0].drive => saturator[1].drive;

and it took me 20 mins to figure out why they sounded different and why were spitting out what it seemed were random values :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant