Star file loading adjustments #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 2D_averages
LorenzLamm
commented
Jun 11, 2024
| normal_data, up_data = vectors_data_from_points_data( | ||
| point_coordinates=point_coordinates, features_table=features_table | ||
| ) | ||
| if features_table is None: |
There was a problem hiding this comment.
in case no normal and up-vectors can be read from the star file, we use the normal vector from the mesh and initialize a random up-vector.
LorenzLamm
commented
Jun 11, 2024
| @@ -76,3 +153,7 @@ def _load_star_file(self, file_path: Path): | |||
|
|
|||
| self.surface_picker.normal_vectors_layer.edge_color = "purple" | |||
| self.surface_picker.up_vectors_layer.edge_color = "orange" | |||
|
|
|||
| self.surface_picker.rotations = features_table[ROTATION] | |||
There was a problem hiding this comment.
These lines are necessary to alter the orientations of loaded positions
LorenzLamm
commented
Jun 11, 2024
| @@ -65,6 +65,11 @@ def vectors_data_from_points_data( | |||
| if len(point_coordinates) == 0: | |||
| # if there are no points, there are no vectors | |||
| return np.empty((0, 2, 3)), np.empty((0, 2, 3)) | |||
|
|
|||
| # check if the features table is empty | |||
| if features_table.empty: | |||
There was a problem hiding this comment.
When loading points, this function was called on an empty features table, leading to an error and thus orientation vectors were not loaded properly in Surforama.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered some issues when loading points from star files into Surforama (even those generated in Surforama).
This PR should fix these issues and also add the functionality to load star files that do not contain orientation information.
In this case, the normal vector is computed from the nearest triangle and a perpendicular up-vector is assigned.
Previous issues:
Please find more details in the commented code.
Let me know what you think :)