From 8cfc6595c2d064c688eb7cc3d8e4ee860f991c0f Mon Sep 17 00:00:00 2001 From: ry061521 Date: Thu, 6 Jul 2023 13:14:55 -0500 Subject: [PATCH] Fix for flickering issue --- .../FlowsheetResultCell.jsx | 6 +- .../FlowsheetResultCell.module.scss | 10 +- .../FlowsheetResultCell.test.jsx.snap | 1184 +++++++++-------- 3 files changed, 637 insertions(+), 563 deletions(-) diff --git a/packages/terra-clinical-result/src/flowsheet-result-cell/FlowsheetResultCell.jsx b/packages/terra-clinical-result/src/flowsheet-result-cell/FlowsheetResultCell.jsx index 136a2bfb3f..61e667786f 100644 --- a/packages/terra-clinical-result/src/flowsheet-result-cell/FlowsheetResultCell.jsx +++ b/packages/terra-clinical-result/src/flowsheet-result-cell/FlowsheetResultCell.jsx @@ -354,7 +354,7 @@ const createFlowsheetResultCellDisplay = (resultDataSet, hideUnit, numericOverfl ); compositeCell.push(endDisplay); - return compositeCell; + return
{compositeCell}
; } const additionalResultsStackDisplay = ( @@ -364,7 +364,7 @@ const createFlowsheetResultCellDisplay = (resultDataSet, hideUnit, numericOverfl ); compositeCell.push(additionalResultsStackDisplay); - return compositeCell; + return
{compositeCell}
; } if (hasAccessoryIcons) { @@ -377,7 +377,7 @@ const createFlowsheetResultCellDisplay = (resultDataSet, hideUnit, numericOverfl compositeCell.push(endAccessoryIconsDisplay); } - return compositeCell; + return
{compositeCell}
; }; const FlowsheetResultCell = (props) => { diff --git a/packages/terra-clinical-result/src/flowsheet-result-cell/FlowsheetResultCell.module.scss b/packages/terra-clinical-result/src/flowsheet-result-cell/FlowsheetResultCell.module.scss index 3fee0e6723..68cd6dde44 100644 --- a/packages/terra-clinical-result/src/flowsheet-result-cell/FlowsheetResultCell.module.scss +++ b/packages/terra-clinical-result/src/flowsheet-result-cell/FlowsheetResultCell.module.scss @@ -12,11 +12,18 @@ padding: 0; } + .combined-display { + display: flex; + flex: 1 1 100%; + margin: 0; + max-width: 100%; // Needed for IE10 truncation + padding: 0; + } + .primary-display { align-items: center; display: flex; flex: 1 1 100%; - // float: left; height: var(--terra-clinical-result-flowsheet-cell-primary-display-height, 1.78571em); // Must use ems for font scaling margin: 0; margin-left: var(--terra-clinical-result-flowsheet-cell-interpretation-icon-reserved-space-margin-left, 1.1875em); // Must use ems for font scaling @@ -38,7 +45,6 @@ .end-display { display: flex; flex: 0 0 auto; - float: right; height: var(--terra-clinical-result-flowsheet-cell-end-display-height, 1.78571em); // Must use ems for font scaling min-width: 0; } diff --git a/packages/terra-clinical-result/tests/jest/flowsheet-result-cell/__snapshots__/FlowsheetResultCell.test.jsx.snap b/packages/terra-clinical-result/tests/jest/flowsheet-result-cell/__snapshots__/FlowsheetResultCell.test.jsx.snap index 95e1c226aa..ab23307f5c 100644 --- a/packages/terra-clinical-result/tests/jest/flowsheet-result-cell/__snapshots__/FlowsheetResultCell.test.jsx.snap +++ b/packages/terra-clinical-result/tests/jest/flowsheet-result-cell/__snapshots__/FlowsheetResultCell.test.jsx.snap @@ -5,48 +5,52 @@ exports[`FlowsheetResultCell correctly applies the theme context className 1`] = className="flowsheet-result-cell padding-compact orion-fusion-theme" >
- + -
-
+ /> +
+
- @@ -57,48 +61,52 @@ exports[`FlowsheetResultCell paddingStyle should render when given compact 1`] = className="flowsheet-result-cell padding-compact" >
- + -
-
+ /> +
+
- @@ -109,48 +117,52 @@ exports[`FlowsheetResultCell paddingStyle should render when given none 1`] = ` className="flowsheet-result-cell" >
- + -
-
+ /> +
+
- @@ -161,48 +173,52 @@ exports[`FlowsheetResultCell paddingStyle should render when given standard 1`] className="flowsheet-result-cell padding-standard" >
- + -
-
+ /> +
+
- @@ -213,49 +229,53 @@ exports[`FlowsheetResultCell should pass hideUnit down 1`] = ` className="flowsheet-result-cell padding-compact" >
- + -
-
+ /> +
+
- @@ -292,37 +312,41 @@ exports[`FlowsheetResultCell should render a entered-in-error status standard re className="flowsheet-result-cell padding-compact" >
- -
-
+ +
+
+
-
@@ -359,79 +383,83 @@ exports[`FlowsheetResultCell should render blood pressure correctly with an inte className="flowsheet-result-cell padding-compact" >
- + -
-
+ /> +
+
- - -
- +
+ +
@@ -443,37 +471,41 @@ exports[`FlowsheetResultCell should render both entered-in-error status bloodpre className="flowsheet-result-cell padding-compact" >
- -
-
+ +
+
+
-
@@ -484,70 +516,74 @@ exports[`FlowsheetResultCell should render correctly when a multiple results cel className="flowsheet-result-cell padding-compact" >
- -
-
- -
-
+
+
+
+ +
+
@@ -558,50 +594,54 @@ exports[`FlowsheetResultCell should render correctly with all normal results 1`] className="flowsheet-result-cell padding-compact" >
- + -
-
+ /> +
+
- @@ -612,68 +652,72 @@ exports[`FlowsheetResultCell should render correctly with an interpretation and className="flowsheet-result-cell padding-compact" >
- -
-
- -
-
+
+
+
+ +
+
@@ -684,50 +728,54 @@ exports[`FlowsheetResultCell should render correctly with at least 1 critical or className="flowsheet-result-cell padding-compact" >
- + -
-
+ /> +
+
- @@ -738,37 +786,41 @@ exports[`FlowsheetResultCell should render systolic entered-in-error status bloo className="flowsheet-result-cell padding-compact" >
- -
-
+ +
+
+
-
@@ -779,23 +831,27 @@ exports[`FlowsheetResultCell should render when given blood pressure diastolic r className="flowsheet-result-cell padding-compact" >
- + + hideAccessoryDisplays={true} + isTruncated={true} + key="ClinicalResultBloodPressure-111.2" + /> +
`; @@ -805,23 +861,27 @@ exports[`FlowsheetResultCell should render when given blood pressure systolic re className="flowsheet-result-cell padding-compact" >
- + + /> +
`; @@ -831,48 +891,52 @@ exports[`FlowsheetResultCell should render when given result data 1`] = ` className="flowsheet-result-cell padding-compact" >
- + -
-
+ /> +
+
- @@ -883,21 +947,25 @@ exports[`FlowsheetResultCell should render when given result data with no event className="flowsheet-result-cell padding-compact" >
- + + /> +
`;