Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation generates CertificatesRequests repeatedly until blocked by letsencrypt #14

Open
lmiranda opened this issue Aug 22, 2022 · 1 comment

Comments

@lmiranda
Copy link

lmiranda commented Aug 22, 2022

The following annotation generates CertificatesRequests in a row and Lets Encrypt block it for requesting too many certificates for the same domain.
cert-manager.io/duration: 2160h cert-manager.io/issuer-kind: ClusterIssuer cert-manager.io/issuer-name: letsencrypt-clusterissuer cert-manager.io/renew-before: 360h

@maelvls
Copy link
Member

maelvls commented Dec 15, 2023

Hi.

This issue is probably caused by the "limited" renewal logic in openshift-routes. Right now, there isn't any error backoff mechanism in place, meaning that I would not recommend using openshift-routes with Let's Encrypt or any service that has a rate limit.

In #34 (comment), similar concerns were raised: openshift-routes re-implements cert-manager's renewal mechanism, and I think openshift-routes should have gone simpler by creating Certificate resources and letting cert-manager handle retrials and such rather than re-implementing the whole issuance logic.

Fixing this issue will take work as I think we need to start creating Certificate resources rather than hurting ourselves with reimplenting the certificate renewal logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants