Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Split Deployer class #5

Open
cerus opened this issue May 29, 2021 · 3 comments
Open

Feature: Split Deployer class #5

cerus opened this issue May 29, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@cerus
Copy link
Owner

cerus commented May 29, 2021

The Deployer class is a little big at the moment and it is expected to grow. This will eventually lead to messy code and thats what we are trying to avoid. A solution to this would be to split the class into multiple classes. This is also a great way to get a little more abstraction into the code base.

This is what I imagined:

  • Create some sort of task interface with some sort of run method
  • execSsh and execCommands will be moved into their respective classes which implement the task interface
  • Create instances of the task classes in the Deployer class and call them when needed

I think this would greatly improve the code. If you have any other solution idea please let me know!

Please comment if you would like to work on this.

@cerus cerus added enhancement New feature or request good first issue Good for newcomers labels May 29, 2021
@lus
Copy link

lus commented May 31, 2021

Hippity Hoppity this issue is now my property.

@cerus
Copy link
Owner Author

cerus commented May 31, 2021

Hippity Hoppity this issue is now my property.

As you wish. Please make sure to follow the contribution guidelines :)

(In regards to rule 1: you don't need to create an issue since this one already exists.)

@cerus
Copy link
Owner Author

cerus commented Sep 9, 2021

Issue is available again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants