Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Update FADI to use the new helm repos instead of the archived repos ( stable & incubator ) #30

Merged
merged 6 commits into from
Jan 11, 2021

Conversation

AyadiAmen
Copy link
Contributor

@AyadiAmen AyadiAmen commented Dec 9, 2020

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

The helm repos stable and incubator are no longer supported which affects most of the helm charts used on FADI, This PR updates the repos with the new ones alongside using the new version of the NiFi helm chart ( ldap support ), the new version of the Postgres helm chart ( cronjob pull policy ) and adding Drupal.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

banzo and others added 4 commits November 10, 2020 00:06
Tested on minikube v1.13.1, kvm, helm v3.0.2, kubernetes v1.19.2
Upgrade Nifi chart to ~0.5
@banzo
Copy link
Contributor

banzo commented Dec 10, 2020

@AyadiAmen please provide a more informative title for the PR and a more detailed description.

@AyadiAmen AyadiAmen changed the title Update/repo Update FADI to use the new helm repos instead of the archived repos ( stable & incubator ) Dec 11, 2020
@AyadiAmen
Copy link
Contributor Author

@banzo thank you for your review, the title and description are changed .

@alexnuttinck
Copy link
Contributor

the CI shows that there is a bug with node-red. It should be fixed before we can merge.

@banzo banzo linked an issue Jan 7, 2021 that may be closed by this pull request
@banzo
Copy link
Contributor

banzo commented Jan 7, 2021

The CI complains about something in the publish gist:

...
remote: Compressing objects: 100% (292/292), done.        
remote: Total 900 (delta 193), reused 187 (delta 44), pack-reused 562        
Receiving objects: 100% (900/900), 12.37 MiB | 78.18 MiB/s, done.
Resolving deltas: 100% (514/514), done.
>> Add helm repos...
Error: looks like "https://kubernetes-charts-incubator.storage.googleapis.com" is not a valid chart repository or cannot be reached: failed to fetch https://kubernetes-charts-incubator.storage.googleapis.com/index.yaml : 403 Forbidden
...

@alexnuttinck what do you think about putting that file in https://github.com/cetic/helm-charts instead of a gist?

@alexnuttinck
Copy link
Contributor

@banzo It is due to the deprecation of the stable and incubator helm charts repos. I will fix the script. Ok I can move the script in a repo.I found that using Gist was approriate for a single Bash script used for multiple projets.

@alexnuttinck alexnuttinck self-assigned this Jan 7, 2021
Copy link
Contributor

@alexnuttinck alexnuttinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems time to merge this PR.

@alexnuttinck alexnuttinck changed the base branch from master to develop January 11, 2021 09:32
@alexnuttinck alexnuttinck merged commit 30c20b2 into develop Jan 11, 2021
@banzo banzo deleted the update/repo branch April 11, 2022 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node-Red disabled
3 participants