task: [Sign & Submit] Display field-level alerts as Errors instead of Warnings #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meissadia
requested review from
billhimmelsbach and
tanner-ricks
as code owners
… intro paragraph
meissadia
commented
Nov 19, 2024
Comment on lines
+53
to
78
| alertStatus?: AlertFieldLevelType; | ||
| } | ||
|
|
||
| export function DisplayField({ | ||
| label, | ||
| value, | ||
| className, | ||
| fallbackValue, | ||
| alertStatus, | ||
| }: DisplayFieldProperties): JSX.Element { | ||
| const resultingValue = value ?? fallbackValue; | ||
| const showAlert = [LAPSED, NOT_PROVIDED].includes(resultingValue as string); | ||
|
|
||
| return ( | ||
| <div className={classNames('display-field', className)}> | ||
| {label ? ( | ||
| <Heading className='h4 break-all' type='3'> | ||
| <Heading className='h4' type='3'> | ||
| {label} | ||
| </Heading> | ||
| ) : undefined} | ||
| <p className='u-mt10 break-all'>{resultingValue}</p> | ||
| <p className='u-mt10'>{resultingValue}</p> | ||
| <AlertFieldLevel | ||
| status='warning' | ||
| status={alertStatus} | ||
| isVisible={showAlert} | ||
| message={NotProvidedAlertMessage[label as string]} | ||
| /> |
There was a problem hiding this comment.
Allow field-level alerts to be displayed as either error or warning
meissadia
commented
Nov 19, 2024
| @@ -194,6 +195,7 @@ export function FilingSubmit(): JSX.Element { | |||
| heading='Confirm your financial institution identifying information' | |||
| data={institution} | |||
| description={getDescriptionForSignAndSubmitSection()} | |||
| alertStatus='error' | |||
There was a problem hiding this comment.
Show Sign and Submit page alerts as "errors"
meissadia
commented
Nov 19, 2024
| isError: boolean; | ||
| }): JSXElement { | ||
| const { lei } = useParams(); | ||
| const isRoutingEnabled = getIsRoutingEnabled(); | ||
| const navigate = useNavigate(); | ||
|
|
||
| const dataIsMissing = isError || !data; |
There was a problem hiding this comment.
All of these checks for !data are to appease the linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1053
Sorry, this turned into a stir fry with lots of language updates mixed in.
Changes
datawhen API calls failScreenshots