Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0 #46

Open
sandstrom opened this issue Jun 21, 2022 · 3 comments
Open

Release 1.0 #46

sandstrom opened this issue Jun 21, 2022 · 3 comments

Comments

@sandstrom
Copy link

This seems pretty stable and popular.

Would be nice with a 1.0 to signal that this is a stable, living project.

image

https://www.ruby-toolbox.com/projects/json_expressions

@chancancode
Copy link
Owner

Hey, thank you for suggesting that. This just didn't happen to be something I personally use so I have no idea if it's still useful/idiomatic/working in modern Rubies. It sounds like you believe it is though, so that's great news!

If this is still a useful (and stable, as you said) project, I think a 1.0 release would be a good idea, but as part of that we should probably also: 1) switch to GitHub Actions for CI, 2) clarify and matrix-test the supported versions of Ruby, 3) probably switch to publishing from CI (so we don't have to separately manage GitHub vs RubyGems permissions). Is that something that you would be interested in picking up? If so, to be happy to add you as a maintainer too.

cc-ing @MiroslavCsonka to see what they think, since they did the last release.

@MiroslavCsonka are you 1) still using this project and/or 2) still interested in remaining a maintainer? The latter doesn't necessarily amount to a lot of commitment, as @sandstrom suggested this appears to be a pretty stable/mature project. As long as you are still somewhat interested, we can keep things as they are, but on the other hand, if you don't have time/interest then I am also happy to remove your access to lower the potential for compromises.

@sandstrom
Copy link
Author

sandstrom commented Jun 22, 2022

Good question!

I actually haven't used it yet. I was evaluating it for our tests, but I haven't really looked at alternatives much, so I don't really know if (as you say) it's still idiomatic ruby.

If we'd end up using it I could consider it, but for now I have to pass (sorry!).

I was just making the assumption based on the stats, but maybe that's not a relevant metric.

(I agree with your arguments too, it may not make sense to spend energy on a 1.0, if the usage stats are mostly "legacy" use; don't know if that's the case though)

@MiroslavCsonka
Copy link
Collaborator

Hey @chancancode , I'm sorry, but I long left the company where we used this gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants