Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-based polymorphism #612

Open
Eisenwave opened this issue Sep 10, 2024 · 3 comments · May be fixed by #607
Open

Content-based polymorphism #612

Eisenwave opened this issue Sep 10, 2024 · 3 comments · May be fixed by #607

Comments

@Eisenwave
Copy link

Eisenwave commented Sep 10, 2024

Describe the problem you'd like to solve

I have a YAML configuration that contains values which can be strings or objects such as:

# monolingual value
key1: File
# multilingual value
key2:
  en_US: File
  de_DE: Datei

I couldn't find any way to deserialize this into something like MonolingualString or MultilingualString depending on the structure (more specifics at https://stackoverflow.com/q/78966200/5740428). I would have to specify the type in a !<type> or type: tag, and that's unnecessary.

Besides this use case, one could easily imagine providing RGB colors either as "#ff0000" hex code strings or { r: 255, g: 0, b: 0 } objects.

Describe the solution you'd like

Something similar to https://github.com/Kotlin/kotlinx.serialization/blob/master/docs/json.md#content-based-polymorphic-deserialization, i.e. content-based polymorphism.

Describe alternatives you've considered

No response

Additional context

No response

@charleskorn
Copy link
Owner

Would what has been proposed in #607 be suitable for your use case?

@Eisenwave
Copy link
Author

Yes, that seems sufficient.

@charleskorn charleskorn linked a pull request Sep 15, 2024 that will close this issue
2 tasks
@sschuberth
Copy link
Contributor

Would what has been proposed in #607 be suitable for your use case?

I'm as well in need of a JsonContentPolymorphicSerializer equivalent.

@charleskorn could you please find the time to move forward with the review of the related PRs by @Jojo4GH?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants