Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smaller Codebase #1501

Merged
merged 32 commits into from
Feb 1, 2024
Merged

Smaller Codebase #1501

merged 32 commits into from
Feb 1, 2024

Conversation

auguwu
Copy link
Member

@auguwu auguwu commented Jan 26, 2024 •
edited
Loading

This PR puts most of the crates into its own bundle crate (just as charted).

@auguwu auguwu marked this pull request as draft January 26, 2024 22:10
@auguwu auguwu self-assigned this Jan 26, 2024
@auguwu auguwu added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code rust Pull requests that update Rust code labels Jan 26, 2024
This was linked to issues Jan 26, 2024
[Feature] Multiple authenticators for sessions #554
Open
Do not allow users and organization names to be the same #759
Closed
Server Ratelimits #1083
Open
Redesign modules that require generics #1100
Closed
Validate NameOrSnowflake in Path<NameOrSnowflake> declarations #1217
Closed
Hyper v1 #1328
Closed
spotlightishere
spotlightishere approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@spotlightishere spotlightishere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A screenshot of Twitter DMs, augmenting a popular meme. Three messages are present: "I ain't reviewing all that", "i'm happy for u tho", "or sorry that happened".

In all seriousness - this is a very large pull request :)
Based on a quick cursory look at pertinent parts, this looks good. I'm excited about the Hyper and authentication related changes - @auguwu, thank you for taking the time to tackle these issues!

@spotlightishere
Copy link
Contributor

@auguwu Wanted to check in on this - would it make sense to go ahead and merge this into main as-is? Although this PR is currently a draft, it may be a good idea to go ahead and merge things in so that history isn't as messy!

If you'd like, I'd be happy to sort out conflicts and try to get this in a mergeable state!

@spotlightishere spotlightishere marked this pull request as ready for review February 1, 2024 18:37
@spotlightishere spotlightishere merged commit 60ee08c into main Feb 1, 2024
18 checks passed
@spotlightishere spotlightishere deleted the feat/smaller-codebase branch February 1, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spotlightishere spotlightishere spotlightishere approved these changes

@IceeMC IceeMC Awaiting requested review from IceeMC IceeMC is a code owner

Assignees

@auguwu auguwu

Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request javascript Pull requests that update Javascript code rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
2 participants
@auguwu @spotlightishere