Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are tests still maintained? #107

Open
giokara-work opened this issue Feb 9, 2024 · 2 comments
Open

Are tests still maintained? #107

giokara-work opened this issue Feb 9, 2024 · 2 comments

Comments

@giokara-work
Copy link
Contributor

giokara-work commented Feb 9, 2024

In an attempt to use the OpenSTL repo with the Bazel build system, we have been trying to run the tests under tests/ directory. However it seems many of the import functions/files/modules are missing, e.g.

  • tests/test_datasets/test_pipelines/test_auto_augment.py imports build_loss in openstl.models which does not exist from a quick search.
  • tests/test_datasets/test_dataset_vis.py: import mmcv but mmcv is not part of the files in the requirements/ directory.
  • tests/test_datasets/test_dataset_vis.py imports from openstl.models.utils.visualization however there is no utils python file/folder in openstl.models.
  • tests/test_models/test_convlstm.py calls ConvLSTM_Model from openstl.models but never passes num_layers, num_hidden and configs arguments which are required according to the contents of openstl/models/convlstm_model.py.

Are these tests still reliable to use? If so, could you pinpoint what I'm missing to run them?

@giokara-work
Copy link
Contributor Author

Seems like the test code was added only recently in #91 by @Jacky1128. Any hints on what I'm missing here to run those?

@chengtan9907
Copy link
Owner

I'm sorry for the confusion. The test code seems to be unreliable at this stage. We should fix and upate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants