-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unresolvable requirements file #103
Comments
I think I'm unfairly blaming WFDB. According to the error here, we are requiring a version of AtriumDB that doesn't exist: chorus_waveform/requirements.txt Line 1 in 426cbc8
|
@tompollard , yes, this is expected. @WilliamDixon provided an early version of 2.4 and the code that depends on that has been merged. I believe the new package should be released publicly very soon. |
I see, in this case the requirements should be updated to use the new version (e.g. to pip install from |
@tompollard @briangow I have a new PR up that works with the newly release atriumdb 2.4.0 and have updated the requirements.txt to reflect that. |
In the future if I make a PR that depends on pre-released features, I'll be sure to use syntax like this so its available for everyone automatically. |
thanks will! |
Tests are currently failing because the dependencies in requirements.txt cannot be resolved. e.g. see: https://github.com/chorus-ai/chorus_waveform/actions/runs/11406512755/job/31740432168
Most likely the cause is that wfdb-python is currently incompatible with Numpy V2 (see: MIT-LCP/wfdb-python#493).
The text was updated successfully, but these errors were encountered: