Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Debugger #187

Open
rachtibat opened this issue Jun 2, 2023 · 2 comments
Open

Feature Request: Debugger #187

rachtibat opened this issue Jun 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@rachtibat
Copy link
Contributor

Hey,

I think it would be really nice, if we could check if the composite actually attached to all the modules we named and to see if there are any modules left that have no rules attached to.
In the long run - but much more difficult to realize - it would be nice to see, if there are any non-Module elements that unexpectedly changed the Relevance values.

Best

@rachtibat
Copy link
Contributor Author

Regarding the second feature "detecting unexpectedly changed relevance values", this could be implemented by introducing a new rule/hook that

  1. returns fixed relevance values, e.g. torch.ones_like(input.shape) * 42.
  2. and then checks at the input whether the gradient_inputs == our fixed values.

Best

@chr5tphr
Copy link
Owner

chr5tphr commented Jun 9, 2023

Hey Reduan,

yes, I think checking whether the composite assigned the rules correctly is a nice feature to have, as this is also done inside the tests. One sanity check that I also would like to introduce is #147, which is somewhat related.

Checking whether the gradient was modified in between rules may be a little challenging for anything that is not feed-forward, as the gradients may not be passed in the same order as they are defined within the model, but there might be a an elegant way to do it.

@chr5tphr chr5tphr added the enhancement New feature or request label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants