Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Draft and add issues and pull requests templates #4

Open
2 tasks done
xames3 opened this issue Oct 27, 2024 · 4 comments
Open
2 tasks done

[Maintenance] Draft and add issues and pull requests templates #4

xames3 opened this issue Oct 27, 2024 · 4 comments
Assignees
Labels
awaiting changes pull requests that need updates or corrections based on feedback community contributions from the community or enhancements that support community engagement discussion needed pull requests that need community or team input before moving forward documentation updates, additions, or improvements to the project’s documentation enhancement enhancements to existing functionality or the addition of new features or content good first issue pull requests related to issues that are ideal for newcomers to start with help wanted extra attention is needed and appreciate some help high priority pull requests that should be reviewed and merged as a priority due to their importance open science contributions that enhance transparency, reproducibility, or accessibility in line with Open Science question further information is requested by the team members or community ready for review pull requests that are finished and awaiting review by the team or community

Comments

@xames3
Copy link
Collaborator

xames3 commented Oct 27, 2024

  • this is a more involved but not a technically challenging issue and could be worked upon in future patches as well. but as of now, it would be ideal to have the below set of acceptance criteria for this successful closure of this issue:

    • need to experiment and draft a relatively simple, easy to follow along and more welcoming pull requests and issue templates. like with every other large scale open-source project, there are million different ways to do this and have a template in place. but for our project and given the level of technical understanding with our contributors, we need to figure out a simple, easy and a less sophisticated way to allow contributors to raise these task. possible good to have template criterion would be:
      • a template which asks why and what
      • template which considers various change types i.e bug fixes, features, tests, etc.
      • template with relative reference links capabilities to address the respective issues.
      • it would be ideal if the template could also allow the contributors to get more specific with their respective platforms as it might be an issue sometimes but certainly not a strict enforcement to have. given what we aim to get out of this repository, it would be very unlikely that contributors would run into platform related issues but still a good possibility to consider.
      • it would be ideal to have a checklist of some obvious tasks before or while the pull request or issue is being opened.
      • one good to have add on would be addressing licensing.
      • allowing optional screenshots, maybe?
    • consider a possibility of multiple templates as it is not natively supported by GitHub as of now. but there is a workaround mentioned in this SO post and a community request.

these are some good references for this issue: GitHub pull request template and How to Create a Good Pull Request Template.

note: this is not an exhaustive list by any means. please explore more options and other open-source repositories on GitHub or StackOverflow using the advanced search filtering option.

@xames3 xames3 self-assigned this Oct 27, 2024
@xames3 xames3 converted this from a draft issue Oct 27, 2024
@xames3 xames3 added documentation updates, additions, or improvements to the project’s documentation enhancement enhancements to existing functionality or the addition of new features or content good first issue pull requests related to issues that are ideal for newcomers to start with help wanted extra attention is needed and appreciate some help question further information is requested by the team members or community community contributions from the community or enhancements that support community engagement discussion needed pull requests that need community or team input before moving forward high priority pull requests that should be reviewed and merged as a priority due to their importance open science contributions that enhance transparency, reproducibility, or accessibility in line with Open Science labels Oct 27, 2024
@xames3 xames3 moved this to Backlog in TOPS SCHOOL NLU Tasks Nov 1, 2024
@xames3 xames3 linked a pull request Nov 5, 2024 that will close this issue
@xames3 xames3 removed a link to a pull request Nov 5, 2024
@xames3 xames3 moved this from Ready to In progress in TOPS SCHOOL NLU Tasks Nov 6, 2024
@xames3 xames3 linked a pull request Nov 6, 2024 that will close this issue
@xames3
Copy link
Collaborator Author

xames3 commented Nov 6, 2024

  • @jfmartinez4, please review the issue. have added a bug reporting issue template and a PR template which can certainly help contributors when raising an issue or reporting a bug or raising a PR.
  • shall add one more issue template for feature/documentation request soon.

@xames3 xames3 added awaiting changes pull requests that need updates or corrections based on feedback ready for review pull requests that are finished and awaiting review by the team or community labels Nov 6, 2024
@jfmartinez4
Copy link
Collaborator

@xames3 I'm not entirely sure where the template would live and how extensive it has to be. My worry is that having a template will make further roadblocks to make pull requests. How would people access these templates?

@xames3
Copy link
Collaborator Author

xames3 commented Nov 14, 2024

these templates are already added to the repository. the contributors have to just raise a pull request or an issue how they normally do. I'll explain in the coming meeting.

@jfmartinez4
Copy link
Collaborator

@xames3 where would people be able to find the PR templates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes pull requests that need updates or corrections based on feedback community contributions from the community or enhancements that support community engagement discussion needed pull requests that need community or team input before moving forward documentation updates, additions, or improvements to the project’s documentation enhancement enhancements to existing functionality or the addition of new features or content good first issue pull requests related to issues that are ideal for newcomers to start with help wanted extra attention is needed and appreciate some help high priority pull requests that should be reviewed and merged as a priority due to their importance open science contributions that enhance transparency, reproducibility, or accessibility in line with Open Science question further information is requested by the team members or community ready for review pull requests that are finished and awaiting review by the team or community
Projects
Status: In review
Development

Successfully merging a pull request may close this issue.

2 participants