File open issue #589
Comments
|
some smb debug info: |
|
open with notepad: |
|
Could you please check if this problem could be reproduced with the below master branch ? git clone https://github.com/namjaejeon/ksmbd |
|
I checked, master branch still have this problem. |
|
I tried to reproduce it with ultra edit, I can not see any stuck issue. Can you give me packet dump(wireshark or tcpdump) that captured on problem situation ? and want to see your ksmbd.conf file also. |
|
my ksmbd.conf: I think 42:27 to 42:38 and 42:38 to 43:02 makes ultraedit no response. |
|
Can you attach dump file to take a close look ? |
|
ok, but I replace some personal information so some checksum may be not correct. |
|
Can you try to reproduce it again after applying this change to your ksmbd source ? |
|
Yes, the issue still can be reproduced. But with your patch and this patch: The file can be opened without stuck. I don't know if this lock level will cause new issues. This system is big endian, I don't if these patches will cause new issues on little endian systems. |
What issue? print errors("unexpected oplock(0x9)") from ksmbd ? There is no issue on windows client ? |
|
And I would like to check dump file to check "unexpected oplock log". Please share wireshark(or tcpdump) file.... |
No, there is no issue on LE. |
File open stuck issue. only patch oplock.c, it still stuck when open file with ultraedit. |
|
Should we actually convert between cpu and le64 for all req and rsp? Example:: |
|
When save modifiled file in ultraedit, ksmbd print unexpected oplock(0x9) if turn on oplock debug. |
no, it will totally disable ksmbd on big endian systems. |
|
I just test ultraedit on a little endian ksmbd server ,turn on oplock debug when you save file, it also print |
Ah, We don't need to convert persistent/volatile id to LE. Please check this patch. So we should remove all le coversion for persistent/volatile id... |
Good catch!
Okay. I will try to reproduce it on my system. Anyway, Stuck issue seems to be fixed. I will apply the patch. |
|
@darwin787 Can you test stuck issue one more with this patch(namjaejeon@b354725) ? or git clone https://github.com/namjaejeon/ksmbd ? Because I have found more leftover le conversion for fids and remove it in this patch. |
|
No stuck any more . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After upgrade to kernel 5.15 and ksmbd 5.4.7, issue #579 seems disappeard.
But when open a file with ultraedit.exe, there is no response and after about 1 minute, file is opened and size is zero, no content.
no problem with windows notepad.exe.
The text was updated successfully, but these errors were encountered: