Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove cncf label on homepage #2609

Closed

Conversation

paularah
Copy link
Contributor

Thanks for contributing! Please ensure your pull request adheres to the following guidelines:

  • All commits contain a well written commit message and are signed-off (see Submitting a pull request).
  • All code is covered by unit and/or end-to-end tests where feasible.
  • All generated files are updated if needed (see Making changes).
  • Provide a title or release-note blurb suitable for the release notes (see guidelines).
  • Update documentation and write an upgrade note if needed (see guidelines).
  • Are you a user of Tetragon? Please add yourself to the Users doc in the Cilium repository.

Removes the CNCF label on the homepage for reasons we've discussed.

Signed-off-by: Paul Arah <paularah.self@gmail.com>
@paularah paularah requested review from mtardy and a team as code owners June 25, 2024 12:46
Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit bbd112a
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/667abc408106c50008cc5ac7
😎 Deploy Preview https://deploy-preview-2609--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xmulligan
Copy link
Member

I think we should keep this, we just also need to mention that Tetragon is a subproject under Cilium like the website said before the update

Copy link
Member

@xmulligan xmulligan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be updated not removed

@mtardy
Copy link
Member

mtardy commented Jul 1, 2024

for reasons we've discussed

would love to have more context on that discussion 😄

@mtardy mtardy added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Jul 1, 2024
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given Bill's comment:

It should be updated not removed

I don't have more context sorry

@xmulligan
Copy link
Member

The reasons being that right now it looks like Tetragon is a stand alone CNCF project while it is actually under Cilium which is the overarching CNCF project

@mtardy
Copy link
Member

mtardy commented Jul 5, 2024

The reasons being that right now it looks like Tetragon is a stand alone CNCF project while it is actually under Cilium which is the overarching CNCF project

So what would you suggest on "We are a proud CNCF project", just "We are a proud CNCF project under Cilium" ?

@paularah
Copy link
Contributor Author

paularah commented Jul 5, 2024

@mtardy PP will handle the update to this. I'll close this if that's fine with you.

@paularah paularah closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants