Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curses not available on windows #1100

Open
ltalirz opened this issue Mar 12, 2019 · 4 comments · May be fixed by #1134
Open

curses not available on windows #1100

ltalirz opened this issue Mar 12, 2019 · 4 comments · May be fixed by #1134
Labels
bug help wanted windows Issues specific to Windows environment

Comments

@ltalirz
Copy link
Contributor

ltalirz commented Mar 12, 2019

As noticed in the circus feedstock on conda-forge, circus uses curses but it seems curses doesn't work on windows (?).

In this issue, it was mentioned that circus supports windows since version 0.12, so it seems like we are missing something.
How should we build the circus conda package for windows?

possible workarounds

Mentioning also the recipe maintainer @carlodri

@ltalirz
Copy link
Contributor Author

ltalirz commented Dec 29, 2019

It seems to me that the curses library is used in three lines of code only, using two functions:

curses.endwin()

stdscr = curses.initscr()

(introduced in commit 7d062b5 ).

Given that this currently blocks the windows build of circus on conda-forge, it would be great to understand whether this is really necessary or whether endwin() and initscr() can be replaced by something supported on windows.

Mentioning @tarekziade for comment (and @sphuber for info)

Edit: Fixed commit hash

@nuno-andre
Copy link

There are some wheels based on PDCurses to support curses library in Windows. It may help.

@ltalirz
Copy link
Contributor Author

ltalirz commented Jan 7, 2020

Thansk @nuno-andre

So, I guess the idea would be to

  • add a feedstock for windows-curses on conda-forge
  • let the circus feedstock depend on
 - windows-curses  [win]
 - curses  [not win]

Is it possible to create a conda-forge feedstock from a python wheel or does the wheel need to be built by conda?
Apparently you can with conda, just wondering whether there is an example of this on conda-forge...

@nuno-andre
Copy link

nuno-andre commented Jan 12, 2020

It think the best option would be to go with setuptools by adding the platform dependent requirement to setup.py:

install_requires = [
    'psutil', 
    'pyzmq>=17.0',
    'tornado>=3.0,<5.0',
    'six',
    'windows-curses>=2.10;platform_system=="Windows"',
]

This way both pip and conda will be able to install the wheels.

It may also be worth merging #1065 to get better Windows support.

biozz added a commit to biozz/circus that referenced this issue Aug 6, 2020
@biozz biozz linked a pull request Aug 6, 2020 that will close this issue
@biozz biozz added bug windows Issues specific to Windows environment labels Aug 6, 2020
biozz added a commit to biozz/circus that referenced this issue Aug 12, 2020
biozz added a commit to biozz/circus that referenced this issue Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted windows Issues specific to Windows environment
Projects
None yet
3 participants