Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Account with Text-message or Email #164

Open
Wilfongjt opened this issue Mar 6, 2019 · 4 comments
Open

Verify Account with Text-message or Email #164

Wilfongjt opened this issue Mar 6, 2019 · 4 comments
Assignees
Labels
Priority-3 Defer until the next deployment iteration

Comments

@Wilfongjt
Copy link
Collaborator

Wilfongjt commented Mar 6, 2019

Problem

An individual can adopt an unlimited number of storm drains.

Solution

Complicate the new account process by adding a required response/confirmation before enable a new account. Confirmation sent to phone or email.

Tests

  • Add unit test to ensure the format of the email is correct
  • Add unit test to confirm the confirmation of the email
  • Add unit test to ensure the format of the text is correct
  • Add unit test to confirm the confirmation of the text message
@Wilfongjt Wilfongjt added the Priority-3 Defer until the next deployment iteration label Mar 6, 2019
@cara-lgrow
Copy link

using email or phone confirmation is ok with us. We do not want to collect phone numbers if the text verification holds onto that data.

@softwaresteph
Copy link
Contributor

I would suggest the phone number option be a separate enhancement. It's an option I would choose myself for convenience, but adding the framework for SMS is a much larger project than leveraging the existing process for emails.

That being said, I don't think it's a problem to ask for a phone number for verification and text it without permanently storing it.

@softwaresteph
Copy link
Contributor

Database Changes

  • Field that indicates true or false if an email address has been confirmed.

Code Changes

  • When a user clicks the "sign up" button for the first time, (1) an email is sent, and (2) a dialog box comes up with instructions to confirm their email (see below for text content)
  • Modify the Info Window to grey out the Adopt! button and show a "Email confirmation required before adopting" message above the button
  • Add new button in Profile that re-opens the email confirmation dialog so they can request a new confirmation.

Tests

  1. User clicks "sign up" and confirmation email is sent, then dialog box is popped up.
  2. If a user's email is not confirmed, button is not enabled and text shows "Email confirmation required"
  3. Following a confirmation URL changes user's status to confirmed in the database
  4. If a user's email is confirmed, button says "Adopt!" and is clickable.

Email Confirmation Dialog box text (Rough Draft)

Before adopting any drains, you need to confirm your email address! This is to confirm your identity and so we can send you periodic reminders about your adopted drain. Please follow the steps in the email (Subject: "Confirm your email").

If you didn't receive the confirmation email, please check your Spam folder, Bulk Mail folder, Social Tab, or Promotions Tab.

If your email still isn't there, add "TBD@lgrow.com" to your address book and request a new confirmation email below.

Click Here to send a new confirmation email

Email text (Rough Draft)

Cara with LGROW to approve the final draft
Cara will provide the welcome paragraphs for this email #214

(reuse header)
Hi (First Name),
To confirm your email address, please click the button below.
(Confirm Button)

Thanks!
(reuse signature)

Questions / Open Issues

  1. Can a User update their email address? Shouldn't we re-confirm?

@cara-lgrow
Copy link

I don't want the email to get too long, so let's go with this:

(reuse header)
Hi (First Name),
To confirm your email address, please click the button below.
(Confirm Button)

Thanks , (first name), for your interest in adopting a drain in the Lower Grand River Watershed. Once you have clicked the button above, and your email is confirmed, please adopt a drain!

(reuse signature)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority-3 Defer until the next deployment iteration
Projects
None yet
Development

No branches or pull requests

3 participants