Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change canned Facebook and Twitter text and image wonky in preview #196

Open
cara-lgrow opened this issue Mar 19, 2019 · 8 comments
Open

Change canned Facebook and Twitter text and image wonky in preview #196

cara-lgrow opened this issue Mar 19, 2019 · 8 comments
Assignees
@Wilfongjt @boekesteine @softwaresteph
Labels
Priority-2 Non-vital function, include in upcoming deployment if time permits review Work completed, waiting for feedback on next steps

Comments

@cara-lgrow
Copy link

cara-lgrow commented Mar 19, 2019 •
edited
Loading

The default text for 'sharing' that you adopted a drain on email, FB and Twitter needs to be updated. LGROW will provide
@cara-lgrow cara-lgrow added the Priority-1 Vital function, include in upcoming deploymen label Mar 19, 2019
@softwaresteph softwaresteph mentioned this issue Mar 20, 2019
Merged
@softwaresteph
Copy link
Contributor

Code to change (after PR #199 is merged): is found in adopted_thank_you.html.haml.

@Wilfongjt Wilfongjt added the next label Mar 20, 2019
@cara-lgrow
Copy link
Author

cara-lgrow commented Mar 26, 2019 •
edited by softwaresteph
Loading

Auto-filled language to 'share' on media platforms found below.

Email

I’m a Storm Drain Superhero! I just adopted a drain in the Lower Grand River Watershed!
Visit www.lgrow.org to learn more about the Lower Grand River and how you can adopt a storm drain too!

Facebook

I’m a Storm Drain Superhero! I just adopted a drain in the Lower Grand River Watershed! @LGROW.org #LGROW #KeepYourLakesGreatandYourRiverGrand #AdoptaDrainGrandRiver

Twitter

I’m a Storm Drain Superhero! I just adopted a drain in the Lower Grand River Watershed! @LGROW_GVMC #LGROW #KeepYourLakesGreatandYourRiverGrand #AdoptaDrainGrandRiver

@softwaresteph
Copy link
Contributor

@Ross-Hunter Could I get your help tonight incorporating a FB sharer?

@Ross-Hunter
Copy link
Contributor

Unfortunately, I'm on daddy-duty this evening. In general though you should be able to use off-the-shelf Facebook share javascript widget.

Feel free to slack me any questions and I should be able to respond.

softwaresteph added a commit that referenced this issue Apr 3, 2019
@softwaresteph
Update social media text
be8c6ea 
Contributes to #196
* Update text for email and Twitter sharing
* Remove duplicate smtp section
@ghost ghost added in progress and removed next labels Apr 3, 2019
@softwaresteph softwaresteph mentioned this issue Apr 3, 2019
Merged
@softwaresteph softwaresteph added review Work completed, waiting for feedback on next steps and removed in progress labels Apr 3, 2019
@softwaresteph softwaresteph added QA LGROW confirm the UI feature's actual function is as expected. and removed review Work completed, waiting for feedback on next steps labels Apr 4, 2019
@cara-lgrow
Copy link
Author

When you click on the FB icon to share that you adopted a drain, our text does not autofill, instead it looks like this:
fb.png

@cara-lgrow cara-lgrow added QA-Failed LGROW found issue incomplete. Create new issue, Add reference to this issue. and removed QA LGROW confirm the UI feature's actual function is as expected. labels May 3, 2019
@softwaresteph
Copy link
Contributor

@cara-lgrow

  1. The wrong image problem is actually one of those funny problems that we caused by always putting the production link in even when we're sharing from staging. That file does not exist in staging anymore.

  2. Facebook doesn't actually allow sharing "text" like Twitter does, unfortunately. The text that is showing is from the site's meta text. I updated it to not say %{context}. Is that good enough or do you want to update the meta text completely?

@softwaresteph softwaresteph reopened this May 7, 2019
@cara-lgrow
Copy link
Author

I think that the %{context} should be replaced with 'Grand River'
However, in the staging site, it still appears incorrect for me- it shows up just as the screenshot shows above when I go to share from the staging site.

@ghost ghost assigned Wilfongjt May 15, 2019
@softwaresteph softwaresteph mentioned this issue May 22, 2019
Merged
@softwaresteph softwaresteph added review Work completed, waiting for feedback on next steps and removed QA-Failed LGROW found issue incomplete. Create new issue, Add reference to this issue. labels May 22, 2019
@Wilfongjt
Copy link
Collaborator

Facebook share is wonky
preview image is too big. but resolves in facebook.
this is confusing...maybe.

@Wilfongjt Wilfongjt removed the Priority-1 Vital function, include in upcoming deploymen label Aug 6, 2019
@Wilfongjt Wilfongjt added the Priority-2 Non-vital function, include in upcoming deployment if time permits label Aug 6, 2019
@Wilfongjt Wilfongjt changed the title Change canned Facebook and Twitter text Change canned Facebook and Twitter text and image wonky Aug 7, 2019
@Wilfongjt Wilfongjt changed the title Change canned Facebook and Twitter text and image wonky Change canned Facebook and Twitter text and image wonky in preview Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wilfongjt Wilfongjt

@boekesteine boekesteine

@softwaresteph softwaresteph

Labels
Priority-2 Non-vital function, include in upcoming deployment if time permits review Work completed, waiting for feedback on next steps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Ross-Hunter @Wilfongjt @boekesteine @cara-lgrow @softwaresteph