Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate publish error with v1.0.0-rc2 and Pogly's C# module #2060

Open
cloutiertyler opened this issue Dec 14, 2024 · 2 comments
Open

Investigate publish error with v1.0.0-rc2 and Pogly's C# module #2060

cloutiertyler opened this issue Dec 14, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@cloutiertyler
Copy link
Contributor

cloutiertyler commented Dec 14, 2024

@RReverser looks like there's a bug on the release/v1.0.0-rc2 branch. I can help you reproduce. It could be an issue with my cherry-picking, but either way let's work on a fix first thing Monday.

To reproduce publish https://github.com/PoglyApp/pogly-standalone/tree/1.0.0-rewrite/server using #2052

Let's add a new regression test for this one as well once we figure it out. It didn't get caught in our automated testing

@cloutiertyler cloutiertyler changed the title Investigate bug with v1.0.0-rc2 and Pogly's C# module Investigate publish error with v1.0.0-rc2 and Pogly's C# module Dec 14, 2024
@cloutiertyler cloutiertyler added the bug Something isn't working label Dec 14, 2024
@RReverser
Copy link
Member

RReverser commented Dec 16, 2024

From a quick glance, it looks like the issue that was fixed by #1987.

The publishing in this case invokes some irrelevant reducer instead of "init" one, and then fails due to argument mismatch. It is similar to the bug I fixed there, with wrong reducers being called.

Can you confirm if that PR was included in the release? It seems like it should be since I made it over a month ago, but just in case.

@RReverser
Copy link
Member

I checked, publish works on master SpacetimeDB, so it's very likely either that PR or something else that was already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants