Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for running plugin verifier every push #10

Open
ericdallo opened this issue Aug 14, 2023 · 2 comments
Open

CI for running plugin verifier every push #10

ericdallo opened this issue Aug 14, 2023 · 2 comments
Labels
CI good first issue Good for newcomers

Comments

@ericdallo
Copy link
Member

No description provided.

@ericdallo ericdallo added good first issue Good for newcomers CI labels Aug 14, 2023
@matuella
Copy link

Just wanted to raise some questions:

  • Can we use the GH actions for this? Do we have some sort of limitation?
  • I'm not sure if I got the verifier part straight, but would it consist of running intellij-plugin-verifier against this plugin? I'm not familiar with IntelliJ plugins, so I would like understand the objective for this check.

@ericdallo
Copy link
Member Author

ericdallo commented Aug 18, 2023

Can we use the GH actions for this?

Absolutely, public repos can use that, clojure-lsp CI uses a lot github CI for tests and release

but would it consist of running intellij-plugin-verifier against this plugin?

Yep, unfortunately, there are some false positives given its Clojure integration in the plugin, but we could check if the output of plugin verifier is the same or it's not increasing

This is the result of plugin verifier for the current release 0.1.4, all red ones are false-positives
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI good first issue Good for newcomers
Projects
Status: Ready for development
Development

No branches or pull requests

2 participants