Refactor to update state when cache or SLURM changes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ties
changed the title
ties
force-pushed
the
feature/separate-slurm-and-cache-update
branch
from
acbf96e
to
32cee50
Compare
Before this commit the new stayrtr state was only recalculated when the validated cache changed. This commit refactors the update loop and separates the actual update from pulling the updated cache. The update is triggered when the SLURM file changes _or_ when the validated cache changes. Should fix cloudflare/gortr#95 and make further changes that trigger an update when an update in the cache has expired easier.
ties
force-pushed
the
feature/separate-slurm-and-cache-update
branch
from
32cee50
to
d11bc15
Compare
|
Running this and saving the metrics. Will see how it behaves. I do not run real routers though so that limits my testing. |
ties
changed the title
|
Seems to have been stable over the last week. Will now run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This was a fairly mechanical change but will require some testing before it really is done. Please check carefully that I got this right :). I felt this could be changed and would make the feature changes easier.
Before this commit the new stayrtr state was only recalculated
when the validated cache changed.
This commit refactors the update loop and separates the actual
update from pulling the updated cache. The update is triggered
when the SLURM file changes or when the validated cache changes.
Should fix cloudflare/gortr#95 and make
further changes that trigger an update when an update in the cache
has expired easier.