Skip to content

Commit

Permalink
Un-pin json gem and update to latest
Browse files Browse the repository at this point in the history
NOTE: there is a change in the underlying behavior of
`JSON.pretty_generate` such that an empty array will now generate `[]`
where before there were two newlines (`\n`) between the brackets like
```
[

]
```

The result of this is that the `RenderedJobInstance#configuration_hash`
for jobs which have empty links _will change_ even though there are no
changes to these jobs.
  • Loading branch information
aramprice committed Nov 20, 2024
1 parent e8fb7c5 commit 93a6e0f
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 7 deletions.
1 change: 0 additions & 1 deletion src/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ gem 'bosh_common', path: 'bosh_common'
gem 'mysql2'
gem 'pg'
gem 'sequel', '~> 5.29.0'
gem 'json', '~> 2.7.0' # TODO to unpin fix bosh-director: rspec ./spec/unit/job_renderer_spec.rb:84

group :development, :test do
gem 'bundle-audit'
Expand Down
3 changes: 1 addition & 2 deletions src/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ GEM
io-endpoint (0.14.0)
io-event (1.7.3)
io-stream (0.6.1)
json (2.7.6)
json (2.8.0)
language_server-protocol (3.17.0.3)
little-plugger (1.1.4)
logger (1.6.1)
Expand Down Expand Up @@ -355,7 +355,6 @@ DEPENDENCIES
bundle-audit
factory_bot
fakefs
json (~> 2.7.0)
minitar
mysql2
parallel_tests
Expand Down
2 changes: 1 addition & 1 deletion src/bosh-director/spec/unit/job_renderer_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ module Bosh::Director
JobRenderer.render_job_instances_with_cache(per_spec_logger, [instance_plan], cache, encoder, link_provider_intents)

expect(instance_plan.rendered_templates.template_hashes.keys).to eq ['dummy']
expect(instance.configuration_hash).to eq('53b2a7cac279af8bb73885b08a794ab5dd21bb8c')
expect(instance.configuration_hash).to eq('d4712f01af58824081e9d964522782da9889cd1b')
expect(instance.template_hashes.keys).to eq(['dummy'])
end

Expand Down
3 changes: 0 additions & 3 deletions src/vendor/cache/json-2.7.6.gem

This file was deleted.

3 changes: 3 additions & 0 deletions src/vendor/cache/json-2.8.0.gem
Git LFS file not shown

0 comments on commit 93a6e0f

Please sign in to comment.