Merge pull request #19 from cloudinary/v1.7.5

v1.7.5
cloudinary · Feb 14, 2019 · 4fe4f50 · 4fe4f50
2 parents 0efe399 + e2eddc0
commit 4fe4f50
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/Model/Configuration.php b/Model/Configuration.php
@@ -159,7 +159,7 @@ public function getCdnSubdomainStatus()
      */
     public function getUserPlatform()
     {
-        return sprintf(self::USER_PLATFORM_TEMPLATE, '1.7.4', '2.0.0');
+        return sprintf(self::USER_PLATFORM_TEMPLATE, '1.7.5', '2.0.0');
     }
 
     /**

diff --git a/Plugin/Catalog/Block/Product/ImageFactory.php b/Plugin/Catalog/Block/Product/ImageFactory.php
@@ -112,21 +112,21 @@ public function __construct(
      * @param  array|null          $attributes
      * @return ImageBlock
      */
-    public function aroundCreate(CatalogImageFactory $catalogImageFactory, callable $proceed, Product $product, string $imageId, array $attributes = null)
+    public function aroundCreate(CatalogImageFactory $catalogImageFactory, callable $proceed, $product = null, $imageId = null, $attributes = null)
     {
-        $imageBlock = $proceed($product, $imageId, $attributes);
+        $imageBlock = call_user_func_array($proceed, array_slice(func_get_args(), 2));
 
         if (!$this->configuration->isEnabled()) {
             return $imageBlock;
         }
 
-        if (class_exists('\Magento\Catalog\Model\Product\Image\ParamsBuilder')) {
-            $this->imageParamsBuilder = $this->objectManager->get('\Magento\Catalog\Model\Product\Image\ParamsBuilder');
-        } else {
-            //Skip on Magento versions prior to 2.3
+        //Skip on Magento versions prior to 2.3
+        if (is_array($product) || !class_exists('\Magento\Catalog\Model\Product\Image\ParamsBuilder')) {
             return $imageBlock;
         }
 
+        $this->imageParamsBuilder = $this->objectManager->get('\Magento\Catalog\Model\Product\Image\ParamsBuilder');
+
         try {
             if (strpos($imageBlock->getImageUrl(), $this->configuration->getMediaBaseUrl() . 'catalog/product') === 0) {
                 $viewImageConfig = $this->presentationConfig->getViewConfig()->getMediaAttributes(

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name": "cloudinary/cloudinary-magento2",
     "description": "Cloudinary Magento 2 Integration.",
     "type": "magento2-module",
-    "version": "1.7.4",
+    "version": "1.7.5",
     "license": "MIT",
     "require": {
         "cloudinary/cloudinary_php": "*"

diff --git a/etc/module.xml b/etc/module.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-  <module name="Cloudinary_Cloudinary" setup_version="1.7.4">
+  <module name="Cloudinary_Cloudinary" setup_version="1.7.5">
       <sequence>
           <module name="Magento_ProductVideo"/>
       </sequence>

diff --git a/marketplace.composer.json b/marketplace.composer.json
@@ -1,7 +1,7 @@
 {
   "name": "cloudinary/cloudinary",
   "type": "magento2-module",
-  "version": "1.7.4",
+  "version": "1.7.5",
   "description": "Cloudinary Magento 2 Integration.",
   "license": "MIT",
   "require": {