Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default import for JavaScript #5

Open
clouedoc opened this issue Jul 21, 2021 · 0 comments
Open

Fix default import for JavaScript #5

clouedoc opened this issue Jul 21, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@clouedoc
Copy link
Owner

clouedoc commented Jul 21, 2021

Importing this plugin in JavaScript projects leads to ugly imports.

Below is the current import line, versus what it should be, in diff format:

- puppeteer.use(require('puppeteer-extra-plugin-timezone').default())
+ puppeteer.use(require('puppeteer-extra-plugin-timezone')())

This issue does not arise with TypeScript projects.

See #3 for example error messages.

@clouedoc clouedoc added the good first issue Good for newcomers label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant