-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ulduar: Convert Auriaya to BossAI and Spell Lists #440
base: master
Are you sure you want to change the base?
Conversation
42277c2
to
e476ab4
Compare
src/game/AI/ScriptDevAI/scripts/northrend/ulduar/ulduar/boss_auriaya.cpp
Outdated
Show resolved
Hide resolved
src/game/AI/ScriptDevAI/scripts/northrend/ulduar/ulduar/boss_auriaya.cpp
Show resolved
Hide resolved
Also move Id: 64456 to the auriaya file |
struct boss_auriayaAI : public BossAI | ||
{ | ||
boss_auriayaAI(Creature* creature) : BossAI(creature, AURIAYA_ACTIONS_MAX), | ||
m_instance(dynamic_cast<instance_ulduar*>(creature->GetInstanceData())), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static cast is enough afaik.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It usually is, but with this I can be 100% certain that the instance is what I think it will be. Yes dynamic_cast is more expensive than static_cast, but in this case it's only invoked once at construction, so I believe the overall impact should be negligible in return for guaranteeing that I can't accidentally call some m_instance->
function that is only available in instance_ulduar
if someone spawns this Boss outside of Ulduar for a giggle for example
src/game/AI/ScriptDevAI/scripts/northrend/ulduar/ulduar/boss_auriaya.cpp
Outdated
Show resolved
Hide resolved
src/game/AI/ScriptDevAI/scripts/northrend/ulduar/ulduar/boss_auriaya.cpp
Outdated
Show resolved
Hide resolved
src/game/AI/ScriptDevAI/scripts/northrend/ulduar/ulduar/boss_auriaya.cpp
Outdated
Show resolved
Hide resolved
Ok feature wise pr is complete, for sql, im missing the defender abilities and the 2 (normal) 4 (hc) creatures that accompany her, also in spell lists. They are both integral parts of the fight. After that, ill give it a test ingame and can be merged. |
Her adds are currently scripted in EAI. I can convert them to spellscript too, but it didn't seem necessary at the time. |
They are such an integral part of the fight in this case that it is kinda necessary. Either way after that we can merge it. |
Alright, will do |
🍰 Pullrequest
This PR converts Auriaya to BossAI and adds Spell Lists
Todo / Checklist