Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance property selectors #14

Open
schuchard opened this issue Apr 7, 2020 · 2 comments
Open

Instance property selectors #14

schuchard opened this issue Apr 7, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@schuchard
Copy link

schuchard commented Apr 7, 2020

Thanks for making this tool!

I have some selectors in a facade that currently aren't being used (small use case I know) but it might be good to show them attached to the facade like in the bottom example vs detached. Or perhaps mark that they're unused?

This is how it's used:

export class SourceFacade {
    emissionCount$ = this.store.select(Selectors.selectEmissionCount);
}

image

@GregOnNet
Copy link
Contributor

Hi @schuchard,

that's a great idea. I did not have Selectors in mind.
Currently, NgRx Vis only works with NgRx's Action Types but I will keep this in mind when I enhance the resolver strategies. 👍

... Or do you mean unused actions?

@GregOnNet GregOnNet added the enhancement New feature or request label Apr 8, 2020
@schuchard
Copy link
Author

Understandable, thanks for considering. I guess both features would be nice, but perhaps that my screenshot was showing an unused action already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants