Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: remove anonymous function allocation isPausiblePortal (0.15% cpu) #135943

Open
mgartner opened this issue Nov 21, 2024 · 0 comments
Open

sql: remove anonymous function allocation isPausiblePortal (0.15% cpu) #135943

mgartner opened this issue Nov 21, 2024 · 0 comments
Assignees
@Dedej-Bergin
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) o-perf-efficiency Related to performance efficiency P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@mgartner
Copy link
Collaborator

mgartner commented Nov 21, 2024 •
edited by exalate-issue-sync bot
Loading

We can move the portal != nil check into the isPausible method rather than allocating an anonymous function on the heap here:

image

Jira issue: CRDB-44799

Epic CRDB-42584
@mgartner mgartner added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) o-perf-efficiency Related to performance efficiency labels Nov 21, 2024
@exalate-issue-sync exalate-issue-sync bot added P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dedej-Bergin Dedej-Bergin

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) o-perf-efficiency Related to performance efficiency P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgartner @Dedej-Bergin