Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: cdc/initial-scan-rolling-restart/normal-checkpoint failed #135974

Closed
cockroach-teamcity opened this issue Nov 22, 2024 · 1 comment · Fixed by #135991
Closed

roachtest: cdc/initial-scan-rolling-restart/normal-checkpoint failed #135974

cockroach-teamcity opened this issue Nov 22, 2024 · 1 comment · Fixed by #135991
Labels
A-cdc Change Data Capture B-runtime-assertions-enabled branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-cdc

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Nov 22, 2024 •
edited by cockroach-jira-scripts
Loading

Note: This build has runtime assertions enabled. If the same failure was hit in a run without assertions enabled, there should be a similar failure without this message. If there isn't one, then this failure is likely due to an assertion violation or (assertion) timeout.

roachtest.cdc/initial-scan-rolling-restart/normal-checkpoint failed with artifacts on master @ 5c5c9d6803d47848aa1960dd6642d5f2c1926814:

(cdc.go:1071).runCDCInitialScanRollingRestart: pq: unknown cluster setting 'jobs.registry.retry.initial_delay'
test artifacts and logs in: /artifacts/cdc/initial-scan-rolling-restart/normal-checkpoint/run_1

Parameters:

  • arch=amd64
  • cloud=gce
  • coverageBuild=false
  • cpu=4
  • encrypted=false
  • runtimeAssertionsBuild=true
  • ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

/cc @cockroachdb/cdc

This test on roachdash | Improve this report!

Jira issue: CRDB-44804
@cockroach-teamcity cockroach-teamcity added B-runtime-assertions-enabled branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-cdc labels Nov 22, 2024
@blathers-crl blathers-crl bot added the A-cdc Change Data Capture label Nov 22, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 22, 2024

This issue has multiple T-eam labels. Please make sure it only has one, or else issue synchronization will not work correctly.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@wenyihu6 wenyihu6 removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Nov 22, 2024
wenyihu6 added a commit to wenyihu6/cockroach that referenced this issue Nov 22, 2024
@wenyihu6
roachtest/cdc: removes dead cluster settings from roachtest/cdc
a2d2087 
Previously, we removed relevant cluster settings to
jobs.registry.retry.initial_delay annd jobs.registry.retry.max_delay but
didn't remove its usage from cdc/initial-scan-rolling-restart. This patch
removes its usage from roachtest/cdc.

Fixes: cockroachdb#135973
Fixes: cockroachdb#135974
Release note: none
@wenyihu6 wenyihu6 mentioned this issue Nov 22, 2024
Merged
wenyihu6 added a commit to wenyihu6/cockroach that referenced this issue Nov 22, 2024
@wenyihu6
roachtest/cdc: removes dead cluster settings from roachtest/cdc
308ceee 
Previously, we removed relevant cluster settings to
`jobs.registry.retry.initial_delay` and `jobs.registry.retry.max_delay` but
didn't remove its usage from `cdc/initial-scan-rolling-restart`. This patch
removes its usage from roachtest/cdc.

Fixes: cockroachdb#135973
Fixes: cockroachdb#135974
Release note: none
wenyihu6 added a commit to wenyihu6/cockroach that referenced this issue Nov 22, 2024
@wenyihu6
roachtest/cdc: remove dead cluster settings from roachtest/cdc
1f8da84 
Previously, we removed relevant cluster settings to
`jobs.registry.retry.initial_delay` and `jobs.registry.retry.max_delay` but
didn't remove its usage from `cdc/initial-scan-rolling-restart`. This patch
removes its usage from roachtest/cdc.

Fixes: cockroachdb#135973
Fixes: cockroachdb#135974
Release note: none
craig bot pushed a commit that referenced this issue Nov 22, 2024
@rail @andyyang890 @wenyihu6
Merge #135772 #135961 #135991
afb085b 
135772: Update Artifact action to v4 r=celiala a=rail

Fixes: DEVINF-1334
Release note: None

135961: changefeedccl: deflake TestChangefeedContinuousTelemetryOnTermination r=asg0451 a=andyyang890

This patch adds some synchronization logic to deflake
`TestChangefeedContinuousTelemetryOnTermination`.
It also simplifies the periodic telemetry logger code.

Fixes: #120837

Release note: None

135991: roachtest/cdc: remove dead cluster settings from roachtest/cdc r=asg0451 a=wenyihu6

**roachtest/cdc: remove dead cluster settings from roachtest/cdc**

Previously, we removed relevant cluster settings to
`jobs.registry.retry.initial_delay` and `jobs.registry.retry.max_delay`
in #135825 but didn't remove its usage from
`cdc/initial-scan-rolling-restart`. This patch removes its
usage from roachtest/cdc.

Fixes: #135973
Fixes: #135974
Release note: none

---

**jobs: remove retryInitialDelaySettingKey and retryMaxDelaySettingKey**

Previously, we removed relevant cluster settings to
`jobs.registry.retry.initial_delay` and `jobs.registry.retry.max_delay`
in #135825. This patch cleans up by removing the unused
constant values referencing them.

Epic: none
Release note: none

Co-authored-by: Rail Aliiev <rail@iqchoice.com>
Co-authored-by: Andy Yang <yang@cockroachlabs.com>
Co-authored-by: Wenyi Hu <wenyi@cockroachlabs.com>
@craig craig bot closed this as completed in 47433b7 Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cdc Change Data Capture B-runtime-assertions-enabled branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-cdc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest/cdc: remove dead cluster settings from roachtest/cdc wenyihu6/cockroach
2 participants
@cockroach-teamcity @wenyihu6