Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More semantic event handling for Unarchiver / Archivers #47

Open
codedread opened this issue Jan 25, 2024 · 0 comments
Open

More semantic event handling for Unarchiver / Archivers #47

codedread opened this issue Jan 25, 2024 · 0 comments

Comments

@codedread
Copy link
Owner

Like was done for commit c3a7b35, we could remove all the Unarchive Event sub-classes in archive/events.js and replace them with @typedef data structures and attach to CustomEvents.

I want to do this for two reason:

  • It provides a better DX for subscribing to events with methods like onExtract() that the IDE can give hints for. We can keep addEventListener() around for backwards-compatibility.
  • It aligns the archive package with the image package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant