Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlights and notes are not getting automatically mapped #9

Closed
coderarjob opened this issue Nov 15, 2022 · 1 comment
Closed

Highlights and notes are not getting automatically mapped #9

coderarjob opened this issue Nov 15, 2022 · 1 comment

Comments

@coderarjob
Copy link
Owner

Description

Highlights and notes are not getting automatically mapped even on pages with one note and highlight.
coderarjob added a commit that referenced this issue Jan 14, 2023
@coderarjob
BugFix: #9 Automatic pair not working
b507a6e 
HighlightNotePairManager.pairAutomatic() loops though each PageResource
and calls pairAutomatic on it. This loop stops at the 1st error, so if
a pairAutomatic call fails, all subsequent page resources are not paired
automatically.

Also in the commit:
* TODO updated
@coderarjob
Copy link
Owner Author

Cause:
HighlightNotePairManager.pairAutomatic() loops though each PageResource
and calls pairAutomatic on it. This loop stops at the 1st error, so if
a pairAutomatic call fails, all subsequent page resources are not paired
automatically.

This came to light due to the #8 bug. Because that exception
is thrown before, no page resource after that is paired automatically.

Fixed in b507a6e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coderarjob