Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook to check for API keys #54

Open
madelinehjenkins opened this issue Nov 3, 2022 · 1 comment
Open

Add pre-commit hook to check for API keys #54

madelinehjenkins opened this issue Nov 3, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@madelinehjenkins
Copy link
Contributor

Rather than manually ensuring that API keys have not been committed, we could do this programmatically via pre-commit hooks. However, due to the diversity in API key format, there does not appear to be an off-the-shelf solution.

Creating new hooks is possible, but in order to make this work with the pre-commit package we would need to make a new git repo for this detect-api-key hook (source). This could be useful to teams beyond ConvAI.

Generally speaking, it's possible to create pre-commit hooks by simply creating a shell script, but in order to integrate with pre-commit it seems like creating a repo that is an installable package or exposes an executable is necessary.

@madelinehjenkins madelinehjenkins added the enhancement New feature or request label Nov 3, 2022
@ammar-s847
Copy link

ammar-s847 commented Dec 30, 2023

Hey, is this still an open issue? I'd love to get started on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants