Largebin field fails with nullable is true and base64 is set

[igormorgado]

Seems there is some issue with LargeBinary and nullable fields when base64 encode is set.

The code:

import databases
import ormar as orm
import sqlalchemy as sa

DB_URL = 'sqlite:///db.sqlite'
database = databases.Database = databases.Database(DB_URL, force_rollback=True)
metadata = sa.MetaData()

class Picture(orm.Model):
    class Meta:
        database = database
        metadata = metadata

    id: int = orm.Integer(primary_key=True)
    name: str = orm.String(max_length=32, nullable=True)
    file: bytes = orm.LargeBinary(max_length=1000000, represent_as_base64_str=True, nullable=True)


async def create():
    engine = sa.create_engine(DB_URL)
    await database.connect()
    metadata.drop_all(engine)
    metadata.create_all(engine)
    pict_a = await Picture.objects.create(name='A picture')
    print(pict_a.json(indent=4))
    await database.disconnect()


if __name__ == '__main__':
    import asyncio
    asyncio.run(create())

The error:

➤ python largebin.py                                                                                                                                                                21/11/03 05:56:20
Traceback (most recent call last):
  File "/home/igor/ormar_test/largebin.py", line 34, in <module>
    asyncio.run(create())
  File "/usr/lib/python3.9/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
    return future.result()
  File "/home/igor/ormar_test/largebin.py", line 25, in create
    pict_a = await Picture.objects.create(name='A picture')
  File "/home/igor/ormar_test/venv/lib/python3.9/site-packages/ormar/queryset/queryset.py", line 1028, in create
    instance = await instance.save()
  File "/home/igor/ormar_test/venv/lib/python3.9/site-packages/ormar/models/model.py", line 73, in save
    self.update_from_dict(
  File "/home/igor/ormar_test/venv/lib/python3.9/site-packages/ormar/models/newbasemodel.py", line 847, in update_from_dict
    setattr(self, key, value)
  File "/home/igor/ormar_test/venv/lib/python3.9/site-packages/ormar/models/newbasemodel.py", line 179, in __setattr__
    if hasattr(self, name):
  File "/home/igor/ormar_test/venv/lib/python3.9/site-packages/ormar/models/descriptors/descriptors.py", line 63, in __get__
    value = base64.b64encode(value).decode()
  File "/usr/lib/python3.9/base64.py", line 58, in b64encode
    encoded = binascii.b2a_base64(s, newline=False)
TypeError: a bytes-like object is required, not 'NoneType'

Or am I doing something very wrong?

PS: If base64 representation is set to "False" , it works nicely. Or if I pass a base64 encoded stream (when base64 is set to True) as

pict_a = await Picture.objects.create(name='A picture', file=base64.b64encode(b'afakepict'))

Also works.

Ugly workaround

An ugly workaround is set the field with a default encoded base64 empty stream as

file: bytes = orm.LargeBinary(max_length=1000000, represent_as_base64_str=True, default=base64.b64encode(b''))

[collerek]

That's a bug I created #409 for this.
Thank you for catching that! :)

[igormorgado]

Glad be able to help.