Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align all sceneobject parameters and move to COMPAS core #174

Open
Licini opened this issue Jun 6, 2024 · 3 comments
Open

Align all sceneobject parameters and move to COMPAS core #174

Licini opened this issue Jun 6, 2024 · 3 comments
Assignees

Comments

@Licini
Copy link
Collaborator

Licini commented Jun 6, 2024

@tomvanmele since you are already making several PRs on Scene Objects, shall we make a list about all the visualization parameters for objects and consolidate them into COMPAS core? So that ideally we don't need to define any of them in viewer

@tomvanmele
Copy link
Member

yes that would be great. there are still quite few things that could be generalised and streamlined...

@PingHsunTsai
Copy link
Collaborator

base on the modification here.
I think it will be good to add

self.highlight_color = Color.yellow()
self.selected = False

self.line_width = 1.0
self.point_size = 1.0

@tomvanmele
Copy link
Member

i have the following notes:

  • all visualisation parameters should be moved to compas.scene.SceneObject
  • for default colors we should use the defaults of the visualisation context. therefore default values of ColorAttribute should be None.
  • viewer and notebook viewer contexts should have a global default for color values, which is used if no specific value is provided by the user. in the case of a CAD environment, we use the default of the CAD environment.
  • surfacecolor shoould be facecolor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants