-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support variants.yml #27750
Comments
Good point, will take a look. |
I'm confused. If we allow folks to use a variants.yaml instead of a conda build config, we're going to break smithy, the bot, and likely other things. Am I missing something? |
I've mentioned this before but I'll say it more explicitly. IMHO we want a drop-in replacement for conda-build that uses the new recipe format. We don't want to have to maintain two parallel tracks of infrastructure outside of the recipe itself. |
Isn't variants.yaml the new conda_build_config.yaml for recipe-v1? |
Idk but right now we use conda build to produce all of the ci support files when rendering with smithy. If we move to variants.yaml, we'll have to retool all of that at minimum. |
I think Nichita has done the work already, and |
But we need to validate and make sure that this is what we want. I think supporting the old style |
Bug:
Currently only conda_build_config.yaml is supported in https://github.com/conda-forge/staged-recipes/blob/main/.ci_support/build_all.py#L111
cc @wolfv
The text was updated successfully, but these errors were encountered: