Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] Update pydantic to >=2.0 #985

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[MAINT] Update pydantic to >=2.0 #985

wants to merge 4 commits into from

Conversation

peytondmurray
Copy link
Contributor

Fixes #984.

Description

This pull request:

  • Updates to pydantic >=2.0.
  • I ran bump-pydantic to automatically update a lot. The only stuff that needed to be done by hand was the validators in schema.py.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2024 •
edited
Loading

✅ Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 5e0f61a
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/673854041f64d6000835a7ec

@peytondmurray
Copy link
Contributor Author

I'm not sure if the upgrade to pydantic>=2 is to blame for this, but it looks like the failing integration test is due to us not parsing the lockfile output of conda-lock using our schema.LockfileSpecification pydantic model. See #986 for more information; this issue seems blocked until that one gets resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soapy1 soapy1 Awaiting requested review from soapy1

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: dependencies 📦 Issues related to conda-store dependencies needs: testing ✅ type: dependency update type: maintenance 🛠
Projects
conda-store 🐍
Status: In review 👀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MAINT] - Upgrade pydantic to >2
1 participant
@peytondmurray