Fix CI #186
Closed
Fix CI #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcurtin
force-pushed
the
github-ci
branch
from
040c6ae
to
a83aaf9
Compare
|
CI is fixed again |
ericcurtin
force-pushed
the
github-ci
branch
from
a83aaf9
to
2d53bd8
Compare
|
@rhatdan we should probably merge this and rebase other PRs before continuing, the tests stopped running... |
ericcurtin
force-pushed
the
github-ci
branch
from
2d53bd8
to
00826d1
Compare
|
This PR appeared to fix CI: but it actually ended up turning off CI. I'm hoping: fixes some of the warnings about "-it" |
ericcurtin
force-pushed
the
github-ci
branch
from
00826d1
to
74ae8bb
Compare
|
Might take a while, multiple tests failing |
ericcurtin
force-pushed
the
github-ci
branch
2 times, most recently
from
339d3c1
to
56d5c15
Compare
ericcurtin
force-pushed
the
github-ci
branch
from
56d5c15
to
2e22fdd
Compare
|
@rhatdan it might be better if you took this PR over me, some tests are broken, been fighting a few hours... bats also isn't running on macOS CI, which isn't ideal... |
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Merged
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
pushed a commit
to rhatdan/ramalama
that referenced
this pull request
Sep 25, 2024
Replaces: containers#186 Use ubuntu 22.04, maybe we can move to 24.04 also in another PR. Signed-off-by: Eric Curtin <ecurtin@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ubuntu 22.04, maybe we can move to 24.04 also in another PR.