Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama-cli made a change #187

Merged
merged 1 commit into from
Sep 25, 2024
Merged

llama-cli made a change #187

merged 1 commit into from
Sep 25, 2024

Conversation

ericcurtin
Copy link
Collaborator

@ericcurtin ericcurtin commented Sep 25, 2024

Now instead of --log-disable we need to redirect stderr to /dev/null:

ggerganov/llama.cpp#9418

@ericcurtin
Copy link
Collaborator Author

ericcurtin commented Sep 25, 2024

Noticed on macOS (because we currently just install the lastest llama.cpp from brew), it is worrying llama-cli regularly makes breaking changes... We may eventually have to stop using the llama.cpp examples like llama-cli, llama-server at some point and write our own application against llama.cpp library like Ollama, etc.

@ericcurtin ericcurtin force-pushed the log-disable branch 3 times, most recently from 4b1ae91 to 29c0fec Compare September 25, 2024 10:53
Now instead of --log-disable we need to redirect stderr to /dev/null:

ggerganov/llama.cpp#9418

Signed-off-by: Eric Curtin <ecurtin@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Sep 25, 2024

LGTM

@rhatdan rhatdan merged commit 3ea3ec6 into main Sep 25, 2024
9 checks passed
@ericcurtin ericcurtin deleted the log-disable branch September 25, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants