Add command completion to Ramalama #200
Open
+49
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
force-pushed
the
completion
branch
6 times, most recently
from
47b2302
to
6add76b
Compare
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
ericcurtin
reviewed
Sep 29, 2024
| @@ -9,8 +9,8 @@ jobs: | |||
| shell: bash | |||
| run: | | |||
| sudo apt-get update | |||
| sudo apt-get install bats bash | |||
There was a problem hiding this comment.
Do we need this installed twice?
argcomplete
There was a problem hiding this comment.
Nope, I think the issue I am seeing is because argcomplete is not in the Container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to move some things around to process in ramalama.py to make this work.
To try this out, you will need to install it and recreate your shell.