Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dark-mode GitHub users #154

Open
datosh opened this issue Aug 16, 2023 · 1 comment
Open

Support dark-mode GitHub users #154

datosh opened this issue Aug 16, 2023 · 1 comment

Comments

@datosh
Copy link

datosh commented Aug 16, 2023

Is your feature request related to a problem? Please describe.
The logo in README.md has a very low contrast ratio (1.37:1) for dark mode users.

Screenshot from 2023-08-16 12-20-29

Describe the solution you'd like
We could add a dark mode friendly version of the image to the repository and conditionally load the correct one, using:

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="docs/images/logo-dark-mode.png">
  <source media="(prefers-color-scheme: light)" srcset="docs/images/logo.png">
  <img alt="Badrobot Logo" src="docs/images/logo.png">
</picture>

Describe alternatives you've considered
Update logo to look good in both modes.

Additional context

@06kellyjac
Copy link
Member

In GitHub you use #gh-light-mode-only #gh-dark-mode-only

<p align="center">
  <a href="https://nixos.org#gh-light-mode-only">
    <img src="https://raw.githubusercontent.com/NixOS/nixos-homepage/master/logo/nixos-hires.png" width="500px" alt="NixOS logo"/>
  </a>
  <a href="https://nixos.org#gh-dark-mode-only">
    <img src="https://raw.githubusercontent.com/NixOS/nixos-artwork/master/logo/nixos-white.png" width="500px" alt="NixOS logo"/>
  </a>
</p>

https://github.com/NixOS/nixpkgs/blob/master/README.md?plain=1#L1-L8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants