Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography consistency (check back once upstream checks for this) #19

Open
cooljeanius opened this issue Jan 5, 2024 · 4 comments
Open

Comments

@cooljeanius
Copy link
Owner

I was recently reminded of the issue wesnoth/wesnoth#7967 which touches on some things that came up when reviewing PR #18 from @MadMax3947 recently; might be worth revisiting if/when the upstream issue is ever closed

@cooljeanius
Copy link
Owner Author

Cross-referencing against: https://forums.wesnoth.org/viewtopic.php?t=57291

@cooljeanius
Copy link
Owner Author

So @k-konami has been working on a translation recently; just a heads-up that fixing this might break some strings in it...

@MadMax3947
Copy link
Collaborator

PR'd a small update for the 1.18 branch which has some string changes so translators have the most up-to-date base to work with.

@cooljeanius
Copy link
Owner Author

PR'd a small update for the 1.18 branch which has some string changes so translators have the most up-to-date base to work with.

Merged, thanks! Leaving this open until upstream issue wesnoth/wesnoth#7967 is closed, though...

@cooljeanius cooljeanius changed the title Typography consistency Typography consistency (check back once upstream checks for this) Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do
Development

No branches or pull requests

2 participants