Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit x/bank v0.47...v0.50 #16505

Closed
1 task done
tac0turtle opened this issue Jun 12, 2023 · 3 comments
Closed
1 task done

Audit x/bank v0.47...v0.50 #16505

tac0turtle opened this issue Jun 12, 2023 · 3 comments
Assignees
@likhita-809
Labels
C:x/bank T: Audit

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Jun 12, 2023 •
edited by testinginprod
Loading

Tasks
Beta Give feedback
  1. fix(x/bank): use a more flexible value codec for bank's denom address index. #16772
    C:x/bank backport/v0.50.x
@tac0turtle tac0turtle mentioned this issue Jun 12, 2023
Closed
52 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jun 12, 2023
@tac0turtle tac0turtle added C:x/bank T: Audit T:Sprint and removed needs-triage Issue that needs to be triaged labels Jun 12, 2023
@likhita-809 likhita-809 mentioned this issue Jun 26, 2023
Merged
19 tasks
@likhita-809
Copy link
Contributor

No core logic changes were found.

  • There is an addition of resolve denom param to query request and flag to GetBalancesCmd()
  • multi send msg and InputOutputCoins takes a single input
  • migration to KVStoreService
  • using logger (from depinject)
  • We are using NewMapCoins instead of sdk coins in genesis

Improvements that could be done:

  • missing few godocs in proto files
  • small improvements in few tests
  • codecov
  • remove GetSigners

@atheeshp
Copy link
Contributor

atheeshp commented Jul 4, 2023 •
edited
Loading

didn't find any major changes, The 1st audit PR changes were looking good.

@atheeshp atheeshp closed this as completed Jul 4, 2023
@atheeshp atheeshp reopened this Jul 4, 2023
@likhita-809
Copy link
Contributor

Reopening the issue as #16772 needs to be addressed as part of the audit

@likhita-809 likhita-809 reopened this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@likhita-809 likhita-809

Labels
C:x/bank T: Audit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexanderbez @tac0turtle @atheeshp @likhita-809