Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: upstream feemarket module #20047

Open
tac0turtle opened this issue Apr 15, 2024 · 1 comment · May be fixed by #21799
Open

[Feature]: upstream feemarket module #20047

tac0turtle opened this issue Apr 15, 2024 · 1 comment · May be fixed by #21799
Assignees
@tac0turtle
Labels
T:feature-request

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Apr 15, 2024 •
edited
Loading

Summary

upstream the auction module from the block sdk. https://github.com/skip-mev/feemarket. This will be coordinated across a few organisations.

Problem Definition

No response

Proposed Feature

Upstream the module
Write docs on alternative way of handling fees.
@tac0turtle tac0turtle changed the title [Feature]: upstream auction module [Feature]: upstream feemarket module Apr 15, 2024
@julienrbrt
Copy link
Member

julienrbrt commented Sep 17, 2024 •
edited
Loading

Just checked the module, a few things need to happen to fit our standards:
Great to see it already supports depinject.

  • usage environment
  • collections support
  • autocli support
  • tx validator support
  • buf module creation
  • extracted in a go.mod (+ ci)
  • rewrite e2e tests to not depend on ibc / interchaintest as system tests
  • use gomock or uber mock for mocks instead of mockery / testify/mock
  • update depinject to module config in gogo instead of pulsar (add go_package to proto)

One thing to consider is renaming the proto to cosmos.feemarket.v1 instead of feemarket.feemarket

@tac0turtle tac0turtle linked a pull request Sep 18, 2024 that will close this issue
Draft
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
T:feature-request
Projects
Cosmos-SDK
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upstream feemarket cosmos/cosmos-sdk
2 participants
@tac0turtle @julienrbrt