[Bug]: state changes during posthandler are ignored if tx is failed

[beer-1]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

If tx failed, all state changes during post handler are trashed.

This is normal if there is no input err == nil on posthandler call, but there is. SDK users may think this post handler can update state to handle tx failure actions due to that inputs. not sure the intension of that field.

If your intension is allowing sdk users to do update state during posthandler to handle tx failure, then please write the state changes on post handler even tx is failed.

Cosmos SDK Version

v0.50

How to reproduce?

No response

[julienrbrt]

In which version 0.50 are you encountering this? This should have been fixed by #18627

[beer-1]

Hey @julienrbrt, thanks for reply.

We are using latest version v0.5.10.

yea seem it is executed, but the state changes are committed only err (from runMsgs) is none.

cosmos-sdk/baseapp/baseapp.go

Lines 1008 to 1013 in 99b4858

	if err == nil {
	if mode == execModeFinalize {
	// When block gas exceeds, it'll panic and won't commit the cached store.
	consumeBlockGas()
	msCache.Write()