Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix consumer chains list pagination #2377

Merged
merged 3 commits into from
Oct 31, 2024
Merged

fix: fix consumer chains list pagination #2377

merged 3 commits into from
Oct 31, 2024

Conversation

freak12techno
Copy link
Contributor

@freak12techno freak12techno commented Oct 28, 2024 •
edited
Loading

Description

Closes: #2305

Fixes the pagination of endpoint to list consumer chains by using FilteredPaginate instead of Paginate.
This only affects the client, so it is not state-breaking.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Oct 28, 2024
@freak12techno freak12techno marked this pull request as ready for review October 28, 2024 22:41
@freak12techno freak12techno requested a review from a team as a code owner October 28, 2024 22:41
insumity
insumity approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@insumity insumity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the fix could also be tested (e.g., in grpc_query_test.go) but otherwise LGTM.

Thank you!

@freak12techno
Copy link
Contributor Author

@insumity I can also add it, if you need

@freak12techno
Copy link
Contributor Author

@insumity can you check once more?

insumity
insumity approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@insumity insumity left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @freak12techno. Note that this needs another approval before it gets merged.

@freak12techno
Copy link
Contributor Author

@insumity I'm not in a hurry or something, this doesn't block me from doing things, so I'm totally ok with waiting.

p-offtermatt
p-offtermatt approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@p-offtermatt p-offtermatt added this pull request to the merge queue Oct 31, 2024
Merged via the queue into cosmos:main with commit 399c833 Oct 31, 2024
16 of 17 checks passed
@freak12techno freak12techno deleted the fix-consumer-chains-list-pagination branch October 31, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-offtermatt p-offtermatt p-offtermatt approved these changes

@insumity insumity insumity approved these changes

Assignees
No one assigned
Labels
C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question]: Endpoint to list consumer chains returns wrong pagination
3 participants
@freak12techno @insumity @p-offtermatt