Make deviceDisplayName
optional in serialized DeviceRegistration
#486
Labels
enhancement
Nice to have, non-functional requirements.
Milestone
When
DeviceRegistration.deviceDisplayName
was introduced (#350), there was some discussion on whether or not it should be optional. I landed on making it optional, but, for some reason still kept the@Required
attribute defined on it, which causes it to always be serialized, even if it isnull
.It sounds like
null
makes a fine default field, which when the name isn't set, shouldn't be serialized.The fact that it was set to
@Required
caused some confusion in another PR which introduced a newDeviceRegistration
field (#484). If it's not needed, it should probably be removed. Doing so will require a version bump of APIs and adding an application service migration to the services which return this type (for backwards compatibility of older clients). This task should thus be bundled with an API upgrade.The text was updated successfully, but these errors were encountered: