-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change some text for CC0 image attribution #134
Comments
Hello, I have a good hand on wordpress plugin development and customization. But almost no with open source, I want to fix this particular issue. Can u please explain a bit more, how I can reproduce this behaviour, I tried to add license in media library, also I added that to a post. But couldn't find attribution text. Please let me know, how I can check the issue? |
Hi @siccovansas, can you please elaborate on what text are you exactly talking about? I added a license to a image and I could see no text generated. |
Hi @nishantwrp, the text I get is generated by the license_html_rdfa function which I call in a script to add the license to media. |
Hi, I still can't get how this function is used to generate licenses for media. Can you please maybe provide some steps/screenshots to reproduce this error? |
@nishantwrp you can find the code in which we call the |
Hi @siccovansas, actually that function is used in this plugin to generate_rdfa on the complete site i.e. by footer or widget. I don't think there is such function for image attributes (@hugosolar please confirm). However, I think you can do something like wp-plugin-creativecommons/src/CC-BY-CC0/block.js Lines 91 to 96 in ce7e1ce
|
Description
When I go to my WordPress Media page and add a CC0 license to an image the generated license text for that image is:
Shouldn't it be something like:
And maybe the "Except where otherwise noted, " should be removed as well when licensing media?
Reproduction
Expectation
Expect text specifying that the license only holds for that image instead of the whole site.
Environment
The text was updated successfully, but these errors were encountered: