Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must click "proceed" for Chooser #48

Closed
cogdog opened this issue Jan 19, 2017 · 2 comments
Closed

Must click "proceed" for Chooser #48

cogdog opened this issue Jan 19, 2017 · 2 comments
Assignees

Comments

@cogdog
Copy link
Contributor

cogdog commented Jan 19, 2017

Maybe for documentation, or perhaps a catch on the modal close- if I do not click the "proceed" link in the chooser, my license change is not done - the first time I did this I close the modal on the "x". Maybe the modal should not have a close or some sort of "apply" button.

@rheaplex rheaplex self-assigned this Nov 11, 2017
@rheaplex rheaplex added this to the 2.1 Release milestone Nov 11, 2017
@rheaplex rheaplex removed their assignment Sep 7, 2018
@r-a-y
Copy link

r-a-y commented Sep 22, 2018

The problem is this relies on changes upstream to the creativecommons.org/choose/ site.

A javascript redirect would probably be better to the parent frame, but the Chooser would need to detect if it is currently in a popup or opened in an external window. Could be possible by checking window.opener.

@TimidRobot TimidRobot added the bug label Jul 17, 2019
@TimidRobot TimidRobot self-assigned this Jul 17, 2019
@TimidRobot
Copy link
Member

We have removed the chooser integration from the plugin for the time being. We hope to add a prettier and better working version back in later: Integrate License Chooser · Issue #70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants