Pull request to test value before using function ctype #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Great job working on a new fork, also got some change in my fork which might be useful, will have a look after my vacation ;) |
preparing php mess detector
preparing php mess detector
because it is not revelent with structure of this library
… properties. Method help test coverage to detect non-tested function (and there are a lot!)
|
I close this pull request, because my fork will create some BC incompatibility, but i will submit a pull request for a next major version when upgrade will be done. |
|
Hello @holtkamp , I have published a 2.0.0-rc.0 version. If you want, you can test it and install it via composer (Be careful to specify the 2.0.0-rc.0 version) A full documentation can be found here: https://doctrine2-spatial.readthedocs.io/en/latest/ Please forgive me, I'm not fluent in english. |
|
Great work @Alexandre-T, will try to have a look coming weeks and report my findings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ws created to Fix #207. But when I saw the reports of codeclimat, the problem with travis, I decided to fork the project to purpose a new release of doctrine2-spatial which can works with the current PHP versions and doctrine versions.